Skip to content

Feat:lazy load discord groups page#2184

Closed
sailingsam wants to merge 5 commits intoRealDevSquad:developfrom
sailingsam:feat/lazyLoadDiscordGroupsPage
Closed

Feat:lazy load discord groups page#2184
sailingsam wants to merge 5 commits intoRealDevSquad:developfrom
sailingsam:feat/lazyLoadDiscordGroupsPage

Conversation

@sailingsam
Copy link

@sailingsam sailingsam commented Sep 25, 2024

Date: 26-09-2024

Developer Name: Saksham Jain


Issue Ticket Number

#2129

Description

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Test Coverage

Screenshot 1 ![Screenshot 2024-09-28 025632](https://github.com/user-attachments/assets/0620b132-e99b-4ac7-9073-8deeeea7d120)

Additional Notes

Frontend PR: RealDevSquad/website-dashboard#852

@sailingsam sailingsam marked this pull request as draft September 25, 2024 22:50
@sailingsam sailingsam marked this pull request as ready for review September 27, 2024 21:36

router.post("/groups", authenticate, checkIsVerifiedDiscord, validateGroupRoleBody, createGroupRole);
router.get("/groups", authenticate, checkIsVerifiedDiscord, getAllGroupRoles);
router.get("/groups", authenticate, checkIsVerifiedDiscord, getPaginatedGroupRoles);

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited. This route handler performs [authorization](2), but is not rate-limited. This route handler performs [authorization](3), but is not rate-limited.
@Achintya-Chatterjee
Copy link
Contributor

closing this PR as it has been fixed by a different PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants